Close stream instead of dispose and fix unit test #3705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#3671 broke our
Core.DeviceTests
DataFetcher
code we were just disposing on Cleanup but this doesn't really do anything useful. It just disconnects the managed peer from the unmanaged peer. This code changes that to close the model if it's an InputStream. The only other type here that we use is aFontImageSourceModel
that doesn't have any resources that need to be cleaned upBitmap
to survive a bit longer so this adds some additional code that tries harder to collect and waitExecutionExceptionEngine
exceptionPR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.